fix(FR-2836): remove unused revision name field from Add Revision modal by agatha197 · Pull Request #7291 · lablup/backend.ai-webui

agatha197 · 2026-05-08T01:07:14Z

Resolves #7290 (FR-2836)

Stacked on top of #7289

Summary

Remove the unused Revision Name text input from the Add Revision modal.
Drop name from the FormValues type and from the addModelRevision mutation payload.
Delete the now-unused i18n keys deployment.RevisionName and deployment.RevisionNamePlaceholder across all 21 supported locales.

Test plan

Open the deployment page and click Add Revision.
Verify the Revision Name input is no longer present.
Submit the modal — the new revision is created without sending a name to the backend.
Confirm no missing-i18n-key warnings appear in the dev console.

agatha197 · 2026-05-08T01:07:28Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Removes the unused “Revision Name” field from the Add Revision modal and cleans up associated frontend plumbing (form typing, mutation payload, and i18n keys) to avoid sending an ignored name value to the backend.

Changes:

Removed the Revision Name form item from DeploymentAddRevisionModal and dropped name from the form value type and mutation variables.
Deleted unused i18n keys deployment.RevisionName and deployment.RevisionNamePlaceholder.
Removed the corresponding translations across all supported resources/i18n/*.json locale files.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
react/src/components/DeploymentAddRevisionModal.tsx	Removes the Revision Name input and stops sending `name` in the `addModelRevision` mutation payload.
resources/i18n/en.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/de.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/el.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/es.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/fi.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/fr.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/id.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/it.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/ja.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/ko.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/mn.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/ms.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/pl.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/pt.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/pt-BR.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/ru.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/th.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/tr.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/vi.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/zh-CN.json	Removes unused `deployment.RevisionName*` translation keys.
resources/i18n/zh-TW.json	Removes unused `deployment.RevisionName*` translation keys.

yomybaby

LGTM

graphite-app · 2026-05-08T09:31:21Z

Merge activity

May 8, 9:31 AM UTC: yomybaby added this pull request to the Graphite merge queue.
May 8, 9:32 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
May 8, 9:32 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
May 8, 9:50 AM UTC: yomybaby added this pull request to the Graphite merge queue.
May 8, 9:52 AM UTC: Merged by the Graphite merge queue.

…al (#7291) Resolves #7290 ([FR-2836](https://lablup.atlassian.net/browse/FR-2836)) > Stacked on top of #7289 ## Summary - Remove the unused `Revision Name` text input from the `Add Revision` modal. - Drop `name` from the `FormValues` type and from the `addModelRevision` mutation payload. - Delete the now-unused i18n keys `deployment.RevisionName` and `deployment.RevisionNamePlaceholder` across all 21 supported locales. ## Test plan - [ ] Open the deployment page and click `Add Revision`. - [ ] Verify the `Revision Name` input is no longer present. - [ ] Submit the modal — the new revision is created without sending a `name` to the backend. - [ ] Confirm no missing-i18n-key warnings appear in the dev console. [FR-2836]: https://lablup.atlassian.net/browse/FR-2836?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions · 2026-05-08T09:51:44Z

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	6.5%	1783 / 27402
🔵	Statements	5.37%	1978 / 36784
🔵	Functions	5.19%	296 / 5699
🔵	Branches	3.77%	1293 / 34255

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/components/DeploymentAddRevisionModal.tsx	0%	0%	0%	0%	88-1194
react/src/components/DeploymentConfigurationSection.tsx	0%	0%	0%	0%	72-300
react/src/components/DeploymentReplicasTab.tsx	0%	0%	0%	0%	40-368
react/src/components/DeploymentRevisionDetail.tsx	0%	0%	0%	0%	26-297
react/src/components/DeploymentRevisionHistoryTab.tsx	0%	0%	0%	0%	59-580
react/src/components/ServiceLauncherPageContent.tsx	0%	0%	0%	0%	121-2198
react/src/pages/EndpointDetailPage.tsx	0%	0%	0%	0%	129-1605

Generated in workflow #483 for commit a14943a by the Vitest Coverage Report Action

github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels May 8, 2026

github-actions Bot assigned agatha197 May 8, 2026

agatha197 mentioned this pull request May 8, 2026

feat(FR-2835): add auto-activate option to Add Revision modal #7289

Merged

5 tasks

agatha197 marked this pull request as ready for review May 8, 2026 01:07

agatha197 requested review from Copilot and yomybaby and removed request for Copilot May 8, 2026 01:07

Copilot started reviewing on behalf of agatha197 May 8, 2026 01:08 View session

agatha197 changed the base branch from feat/FR-2835-add-auto-activate-option to graphite-base/7291 May 8, 2026 02:04

Copilot AI review requested due to automatic review settings May 8, 2026 02:04

agatha197 force-pushed the fix/FR-2836-remove-revision-name-field branch from 28899a8 to 1dad518 Compare May 8, 2026 02:04

agatha197 force-pushed the graphite-base/7291 branch from 56c7a2e to 73e58ea Compare May 8, 2026 02:04

agatha197 changed the base branch from graphite-base/7291 to feat/FR-2835-add-auto-activate-option May 8, 2026 02:04

Copilot started reviewing on behalf of agatha197 May 8, 2026 02:05 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

yomybaby approved these changes May 8, 2026

View reviewed changes

yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from 1dad518 to af491a6 Compare May 8, 2026 09:30

graphite-app Bot changed the base branch from feat/FR-2835-add-auto-activate-option to graphite-base/7291 May 8, 2026 09:32

yomybaby force-pushed the graphite-base/7291 branch from 73e58ea to 316c42a Compare May 8, 2026 09:48

yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from af491a6 to 71dfa8d Compare May 8, 2026 09:48

yomybaby changed the base branch from graphite-base/7291 to main May 8, 2026 09:49

yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from 71dfa8d to 4e858ab Compare May 8, 2026 09:50

graphite-app Bot force-pushed the fix/FR-2836-remove-revision-name-field branch from 4e858ab to a14943a Compare May 8, 2026 09:51

graphite-app Bot merged commit a14943a into main May 8, 2026
11 checks passed

graphite-app Bot deleted the fix/FR-2836-remove-revision-name-field branch May 8, 2026 09:52

github-pages Bot temporarily deployed to github-pages May 8, 2026 09:53 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(FR-2836): remove unused revision name field from Add Revision modal#7291

fix(FR-2836): remove unused revision name field from Add Revision modal#7291
graphite-app[bot] merged 1 commit into
mainfrom
fix/FR-2836-remove-revision-name-field

agatha197 commented May 8, 2026 •

edited by atlassian Bot

Loading

Uh oh!

agatha197 commented May 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

yomybaby left a comment

Uh oh!

graphite-app Bot commented May 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

agatha197 commented May 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

agatha197 commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for react-coverage (./react)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agatha197 commented May 8, 2026 •

edited by atlassian Bot

Loading

agatha197 commented May 8, 2026 •

edited

Loading

graphite-app Bot commented May 8, 2026 •

edited

Loading

github-actions Bot commented May 8, 2026 •

edited

Loading